Is my soul silver pokemon team good?

Yeah your team is good. My only advice is to lose the pichu, unless you already have a thunderstone handy. Pickachu is really weak in this game compared to the other electric pokemon available, and I already have 14 gym badges and I still haven't seen a thunderstone any where.