Did i make the right choose?

so my ex and i dated for 3 yrs there was a promise ring and everything but we fought alot his friends got in the way and he missed are 3 yr anniversary. i was not happy but that was also caused by me feeling worthless and i wanted to talk things out and he didint so i brokeup with him and he tried for 8 mons to get back with me i stake around for those 8 mons to see if he would really change but he never did and all of a sudden he got a new gf and stop talking to me then they broke up and he came back to me and i know he was not done with that girl so i told him to fix it then they trye again and he came back to me then we tryd the friends thing for 2 yr s with hooking up and stuff but i though we were fixing it which is what we talked about but he played me for those 2 yrs so....i wonder should i have gave him that nother try or did ii make the right choose